Merged
Conversation
Users can upload ATLAS coordinates to automatically update the tvec and tilt in the intrument file. This only affects detectors, not image plates. Signed-off-by: Brianna Major <brianna.major@kitware.com>
Collaborator
Author
|
@psavery Let me know if you need data to test this branch with |
Collaborator
Author
|
@saransh13 This is ready for feedback when you have the chance! |
saransh13
approved these changes
Apr 8, 2025
Member
saransh13
left a comment
saransh13
left a comment
There was a problem hiding this comment.
Tested this and the results look correct to me. LGTM
psavery
reviewed
Apr 9, 2025
| from hexrdgui.utils.dialog import add_help_url | ||
|
|
||
|
|
||
| class AtlasConfig: |
Collaborator
There was a problem hiding this comment.
I think it'd be nicer if AtlasConfig was on its own separate file, such as atlas_config.py. But we can leave it for this PR.
psavery
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1761 and HEXRD/hexrd#736